HajimeKawahara/exojax

Code Comprehensive Review

Closed this issue · 4 comments

Based on the reflections from Bug #414 , we will thoroughly inspect the calculations and implementations of the code up to now.

emission spectrum comparison with PetitRadtrans, which was performed when version 1 released, but now many changes since then

  • emission w/ pure absorption #457 See the threads below.

physical settings

opfac * xsmatrix * dParr[:, None] * mixing_ratio[:, None] / (mass * gravity)

opfac is equivalent to 1.e3/m_u, where m_u = scipy.constants.m_u (atomic mass in kg). 1.e3 converts to cgs unit.

mixing_ratio: volume mixing ratio (VMR) or mass mixing ratio (MMR) [N_layer]
mass: mean molecular weight for VMR or molecular mass for MMR

Note: when using MMR as molecular abundance parameters, the spectrum does not depend on the mean molecular weight, and therefore scalable by g, i.e. MMR/g.

constants

  • constants.py

metallicity

  • zsol.py #535 (bug)

continuum

I performed the comparison of the spectra calculated with the pure absorption case with petitRADTRANS. The scripts for these plots are included in tests/integration/comparison/twostream. Exojax calculations were performed with release v1.4.2.

wide_R7000
narrow_R70000
CIA_R70000

Thanks! #457

I realized that it makes more sense to compare intensity-based calculation with petitRADTRANS, the results of which are attached below. The spectra are now much more similar. The scripts for these plots are included in tests/integration/comparison/twostream. Exojax calculations were performed with the develop branch on Jan. 13th (a5409ae).

wide_R7000
narrow_R70000
CIA_R70000

Just updating the figures calculated with petitRADTRANS3. Exojax calculations were performed with release v1.5.
wide_R7000
narrow_R70000
CIA_R70000