HappyTobi/cf-puppeteer

Unable to deploy with new manifest style

Opened this issue · 3 comments

@HappyTobi Thanks for help with --legacy-push. We are using that and it looks good so far!

I wanted to upgrade my manifest since the old syntax is deprecated.

This is our manifest.preview.yml

---
defaults: &defaults
  memory: 1G
  disk_quota: 1G
  buildpacks:
    - ruby_latest_buildpack
  env:
    RAILS_ENV: preview
  services:
    - postgres
    - redis
applications:
  - name: app-test
    <<: *defaults
    command: rails s -p $PORT -e $RAILS_ENV
    env:
      ENABLE_SCHEDULER: true
  - name: sidekiq
    <<: *defaults
    health-check-type: process
    no-route: true
    command: sidekiq -C config/sidekiq.yml

A regular cf push does work. But we get the following with

cf zero-downtime-push app-test -f manifest.preview.yml  --no-start
Applying manifest manifest.preview.yml in org DIDIT / space preview as ankur.sethi@...
Buildpack "ruby_latest_buildpack" must be an existing admin buildpack or a valid git URI
FAILED
FAILED
error while uploading / deploying the application... roll everything back

OK I am seeing the new manifest syntax works with --legacy-push. I guess --legacy-push uses the v2 API and can use the new manifest syntax.

Hi @amalagaura,

normally there should be no error when you are using the plugin because i wrap the cf binaries most of the time (to provide better version compatibility).

--legacy-push use the "normal" cf push command so that should work fine, else please feel free to open a new pr.

The zero-downtime-push without the --legacy-push option uses the cf v3-push command.

Kind regards
Tobi

Thank you. I'll check again once we update our PCF install. I think it is too old, it is on 2.3