Haruno19/starfetch

[edited] Creating an additional program to automatically parse the stars' coordinates for the JSON files

Opened this issue · 4 comments

Munimul commented

Hey, I have noticed that you have only 28 constellations data available. I know there are 88 according to IAU (more!). You are using xy coordinates ranging from 1-10 for y and 1-20 for x if I am correct. what is the procedure you are taking to position the stars? I would like to contribute. Wikipedia has all the 88 svgs available for them. Is there any way we could extract the xy coordinate for all of them in respect to your map size from those files?

Haruno19 commented

Hi! The process I used to assign the x and y coordinates for the first constellations isn't very "scientific"; basically just a trial and error method, positioning the stars in different ways until I found the one that resembled the online images the most.

Given the space limitations to display the graph in the command-line environment, I haven't felt the need to think of an algorithmic way to extract the coordinates directly from images. Since the possible positions in the grid are limited compared to the how many pixels an image has, the tolerance & error margin are high too.
So, I'm sorry but as of now there's no a specific method to automatically extract the coordinates :(

That said, I don't know if the other contributors have used different approaches.

There's no "correct" way to do so, if you still feel like contributing (which you're very welcome too!) please use the method and approach you like the most!

Thank you :)

Munimul commented

Thank you. Once I find a solution. I will create a new pull request.

Haruno19 commented

Thank you! Don't worry about it too much tho, as I said there's no need to make it the perfect representation of the constellation, as long as it resembles it, it's fine :)

Haruno19 commented

I'm keeping this issue open and labeling it as a feature request + help wanted, for anyone reading this issue who might actually wants to try making a parser that can automatically get the stars' coordinates from pictures

It's not a critical priority of course, but still a nice optional feature to have :)