Flow rename plugin doesn't seem to rename files
begunfx opened this issue · 12 comments
I have a rename node in my flow that should append 1080p to the end (this is after a conditional if the size is bigger than 1080p to resize the file then rename it).
The file gets resized and moved to the proper folder. so I know it's moving through the flow as expected.
Attached is my flow and the job report.
Flow Export:
Clean Resize ReTranscode v06.txt
Job Report:
5MG6ciwtjL7-log.txt
Running tdarr via Docker on a Synology server running latest DSM 7.2
Thanks in advance for your help.
The rename has worked or do you mean something else?:
2024-05-21T09:23:31.349Z 5MG6ciwtjL7:Node[TMVaultNode]:Worker[khaki-kiwi]:Attempting move from /temp/test/tdarr-workDir-node-pA_1mDf88-worker-khaki-kiwi-ts-1716307963876/1716307973981/sample__2160__libx264__ac3__30s__video.mkv to /temp/test/tdarr-workDir-node-pA_1mDf88-worker-khaki-kiwi-ts-1716307963876/1716307973981/sample__2160__libx264__ac3__30s__video_1080p.mkv, method 1
2024-05-21T09:23:31.349Z 5MG6ciwtjL7:Node[TMVaultNode]:Worker[khaki-kiwi]:After move/copy, destination file of size 22975649 does match cache file of size 22975649
2024-05-21T09:23:31.349Z 5MG6ciwtjL7:Node[TMVaultNode]:Worker[khaki-kiwi]:Plugin run complete
At the end of the flow you're using Set Original File, this is keeping the original file in the Tdarr DB. Remove it to have the new file in the DB instead.
Thanks for the response @HaveAGitGat. My expectations and understanding on how the flow works is when the file is resized/processed etc. its in the cache folder and then when it's completed it will be physically moved into the output folder I specified in my flow. Before the move the rename should physically rename the file so the file I see in the output folder should have the 1080p appended at the end of the filename. Currently, I'm seeing the file name stay the same after being processed and moved to the output folder still using the original file name. I'm not sure what you mean by "in the Tdarr DB". Perhaps I'm not understanding how the flow is supposed to work, but that is what I thought is supposed to happen.
Please try running my flow on the test file: sample__2160__libx264__ac3__30s__video.mkv (located in the tdarr samples page). I'm seeing it on this file.
If my expectations are incorrect, I would appreciate some further clarification on how the rename should work.
Thanks and great job on this tool!
@HaveAGitGat. Just following up...Any update on this? Thanks!
From the log the rename has occurred on disk:
Please confirm with a screenshot where you are seeing the original file name. Note in explorer or other file browsers you may need to refresh or reload the window for the new filename to show.
I can confirm via my Synology DSM that the file was not renamed. See attached (source and output) files. I'm viewing these within my Synology server's file viewer so caching is not an issue. Additionally I removed the files and tried again to make sure I didn't miss anything...still the same.
@begunfx thanks, seems the rename plugin is actually renaming the file (if you add a 'Require Review' flow plugin after the rename you should be able to see the renamed cache file). It's the Move to Directory file which is causing the issue. Will investigate ty.
This should now be working with this fix:
#655
The issue also affected Copy to Directory and Copy to Working Directory which were implemented before the rename plugin was added. So the rename plugin itself was working fine but then those other plugins were not using the changes.
Re-open if needed thanks.
Awesome. Thanks! Glad you found the issue and were able to fix it. I'll test again when the fix is pushed out.
It’s already been pushed out 👌.
Sweet. I'll give it a try.
Just tested and it works! 👍
Great thanks for the update 🙂