Recent change breaks hashlink builds.

Question

Recent change breaks hashlink builds.

NitroPlum opened this issue 10 months ago · 3 comments

Two people have tried building hashlink and when you try to run it, we get the following error :
src/module.c(574) : FATAL ERROR : Invalid signature for function fmt@mp3_open : PBi_Xfmt_mp3_ required but P_Xfmt_mp3_ found in hdll

We purposefully reverted the changes from this commit and it works afterwards: 102f09b

Answer 1 · 2023-12-04T10:44:59.000Z

The change requires HeapsIO/heaps#1175

Answer 2 · 2023-12-06T01:23:17.000Z

@ncannasse I think you misundertood. As of now, if you pull master and build hashlink, it will build. However the resulting hashlink will not work when you try to run it. If you undo these changes and build, it works great. 102f09b

Answer 3 · 2023-12-06T06:08:01.000Z

I understand well. You need to patch heaps so it works with latest hashlink. Le mer. 6 déc. 2023 à 02:23, NitroPlum ***@***.***> a écrit :

…

@ncannasse <https://github.com/ncannasse> I think you misundertood. As of now, if you pull master and build hashlink, it will build. However the resulting hashlink will not work when you try to run it. If you undo these changes and build, it works great. 102f09b <102f09b> — Reply to this email directly, view it on GitHub <#637 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHZXQFLYTB5JASWIFQZ6JDYH7CJBAVCNFSM6AAAAABAFM7QWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBRHEZDGNRSGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>