HearthSim/HSTracker

[Bob's Buddy] Win probabilities wrong when facing/using Lich King

Closed this issue · 4 comments

Describe the bug
When I play with or against Lich King, the probabilities of winning and average damage are wrong.
I have witnessed:

  • My board losing supposedly 100% in my favour fights when fighting enemy Lich Kings.
  • My board winning supposedly unwinnable fights when using Lich King

To Reproduce

  1. Play with Lich King against an opponent who would 100% win if not for LK Hero Power
  2. OR play against Lich King against an opponent who would 100% lose if not for LK Hero Power

Expected behavior
Correct win % predictions from bob's buddy when playing battlegrounds.

Screenshots
I'll try and get one next time.

Version (please complete the following information):
Version 1.7.6 (2171)

Additional context
I believe the bug is linked to the Lich King Hero Power not being recognised.

I think this has been fixed by ce6b6c8#diff-ba74ab90f2ff2305d54f759cc54eb49fc56d42f5510f20d5ccd4ef4f9d95baef

We should have a new release soon with several fixes, so stay tuned. Basically what's happening is that the hero power is not being taken into account due to a discrepancy with how HDT handled it which got fixed by the mentioned commit. I will leave this open until we have a new release.

Thanks! Didn't see it in the open issue list so thought i should flag. Great to hear you've already fixed it.

Thanks for reporting it. It makes it easier to address it in case it was something that we missed.

Should be fixed in 1.7.7.