HearthSim/HSTracker

Battleground replays

runofthemill opened this issue · 3 comments

When I finish a game of Battlegrounds, the app always notifies me that the replay has been uploaded to HSReplay, but whenever I click the notification the resulting page shows "Replay Not Available". Based on the website, it would seem Battlegrounds matches don't have replays, but the app has an option to upload Battleground matches, and I can see in the app logs that the app is uploading something to S3.

Should the app option be removed?

Cheers!

To Reproduce
Steps to reproduce the behavior:

  1. Play Battlegrounds match (app settings matching screenshot below)
  2. Click on Replay notification after match

Game mode

  • Standard
  • Wild
  • Classic
  • Arena
  • Battlegrounds
  • Duels
  • Tavern Brawl
  • Dungeon Run/Book of Heroes/Book of Mercenaries
  • Single Player

Expected behavior
Either:

  • Replay is uploaded and available when playing Battlegrounds
  • No option (and notification) that a replay has been uploaded after playing a Battleground match

Screenshots
Screen Shot 2022-06-16 at 10 12 21 AM

Screen Shot 2022-06-16 at 10 13 25 AM

Screen Shot 2022-06-16 at 10 09 59 AM

Version (please complete the following information):
Version 2.1.7 (2470)

Additional context
macOS 12.4 (M1 14" MBP)

Log file
hstracker.log
hstracker(1).log (renamed from hstracker.log.1 so I could upload here)

Deck code
N/A

There is no BG replay viewer but you games are tracked and would show up under https://hsreplay.net/battlegrounds/mine if you are a premium subscriber. I will use this issue to disable the ability to click on a replay for modes that don't have a replay viewer in the future.

The upload notification should no longer display for BG/Mercenaries games.

Cheers - thanks for the quick fix!