Not correctly picking up current deck

Question

Not correctly picking up current deck

malcornelius opened this issue 2 years ago · 13 comments

Describe the bug
Seen this behaviour for the last few days - HST seems stuck on one deck, changing decks in HS isnt picked up

To Reproduce
Steps to reproduce the behavior:

See it continuously. Closing and reloading HS and HST sometimes resolves the problem but generally not.

Game mode

[X ] Standard

Expected behavior
Should match selected deck

Screenshots
Can be provided

Version (please complete the following information):
Latest

Additional context
Add any other context about the problem here.

Log file
Attach the hstracker.log file found under /Users/<userid>/Library/Logs/HSTracker/ directory (or use the Help->Open log directory)

Deck code
If the problem happens with a specifi
hstracker.log
c deck, please include the deck code used.

Answer 1 · 2022-12-16T20:57:18.000Z

What deck were you playing?

Deathrattle Rogue or VS Plague Priest

Did you create the deck with the old version? If the deck is listed on HSTracker Deck Manager, delete it there and see if the problem goes away.

Answer 2 · 2022-12-16T21:04:14.000Z

Hi there ! thanks for the quick reply. I tend to swap between three decks - it seems to lock on one of them and not change when i swap decks. Cant remember exactly which the combination was when i reported it but when i play tomorrow i will recreate all the decks and note exactly which. Pretty sure the decks were Newly created the VS one certainly was. Best wishes Malcolm

…

On 16 Dec 2022, at 20:57, Francisco Moraes ***@***.***> wrote: What deck were you playing? Deathrattle Rogue or VS Plague Priest Did you create the deck with the old version? If the deck is listed on HSTracker Deck Manager, delete it there and see if the problem goes away. — Reply to this email directly, view it on GitHub <#1293 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4YZDHROK3ISNP6GWUVO76LWNTJTTANCNFSM6AAAAAATAIQB3Q>. You are receiving this because you authored the thread.

Answer 3 · 2022-12-18T15:14:58.000Z

Is your deck playing Maestra?

Answer 4 · 2022-12-18T15:49:53.000Z

Sorry for the delay in testing this again - I’m suffering from the flu at the moment so just watching the HS WC. I’ll try to play some games tonight. Ive copied and deleted all my decks and recreated them from the codes. No, I dont have Maestra in the DR Rogue deck. Best wishes Malcolm

…

On 18 Dec 2022, at 15:15, Francisco Moraes ***@***.***> wrote: Is your deck playing Maestra? — Reply to this email directly, view it on GitHub <#1293 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4YZDHQPMQJFSWTYVDTUHWLWN4S7ZANCNFSM6AAAAAATAIQB3Q>. You are receiving this because you authored the thread.

Answer 5 · 2022-12-21T13:10:32.000Z

I have the same problem.

Picked my latest Death Knight Blood deck but my aggro druid is detected by HSTracker. Also that deck does not appear in the deck list. But the aggro druid is marked as active.

Just tested with latest version 2.3.4

13:50:30.856 INFO DeckWatcher.run():72 - found deck id: 2220723979
13:50:32.475 DEBUG DecksReader.readFile():52 - Deck: I 13:50:32.4241720 Finding Game With Deck:
13:50:32.482 DEBUG DecksReader.readFile():52 - Deck: I 13:50:32.4241720 ### Aortajackson
13:50:32.484 DEBUG DecksReader.readFile():52 - Deck: I 13:50:32.4241720 # Deck ID: 2220723979
13:50:32.488 DEBUG DecksReader.readFile():52 - Deck: I 13:50:32.4241720 AAECAfHhBAbp0ASY1ASJ5gSX7wSE9gTipAURlugDlrcE9OME/OME/eMEieQElOQEseYEj+0Eh/YEsvcEs/cEvvcEtvoEq4AFopkFl6QFAA==
13:50:32.493 DEBUG DecksReader.readFile():52 - Deck:
13:50:32.500 INFO QueueEvents.handle():31 - Now in queue
13:50:32.502 INFO CoreManager.autoDetectDeckWithMirror():621 - Trying to import deck from Hearthstone
13:50:32.503 INFO CoreManager.autoDetectDeckWithMirror():626 - Found selected deck id via mirror: 2220723979
13:50:32.504 WARNING CoreManager.autoDetectDeckWithMirror():642 - No deck with id=2220723979 found

Answer 6 · 2022-12-21T14:57:42.000Z

Maybe it has nothing to do with this issue, but I am seeing as well decks not imported, whenever there are signature cards in it. Swapping to the regular card the deck actually imports fine.

If this is not the issue here, let me know if you want me to open a specific issue for that particular case

Answer 7 · 2022-12-21T15:45:30.000Z

Good point, the deck in case (death knight) has a signature card in it.

Answer 8 · 2022-12-22T18:51:27.000Z

I agree - its related to Sig cards.

I played with a deck with no sig cards without issue, switched to another without issue but when I tried to switch to my Deathrattle Rogue which has an sig card it failed to swap. I then swapped to another deck with no sig - no issue but when I switched back to DR it again failed to pick it up.
hstracker.log

Answer 9 · 2022-12-22T18:57:10.000Z

Thanks for the confirmation. I found the missing code and I hope to have a release out with a fix available soon. It was the same issue with Diamond cards before but I missed one spot.

Answer 10 · 2022-12-22T19:46:55.000Z

Please try with version 2.3.5. It worked for my limited testing against AI and switching between decks that include signature cards and decks without.

Answer 11 · 2022-12-22T20:59:08.000Z

Seems to have the resolved the issue for my 3 decks.

Thanks for the quick responses !

Answer 12 · 2022-12-22T21:01:44.000Z

Seems to have the resolved the issue for my 3 decks.

Thanks for the quick responses !

Thanks for the confirmation. Once I had enough information on what was wrong, it was an easy fix. I should have looked at the changes made for diamond cards but I just mirrored the changes from HDT and missed one important change. I will probably rewrite that piece of the code to avoid this if they ever introduce the ultra golden marvelous signature cards :-)

I will close the issue down once we get more confirmations.

Answer 13 · 2023-01-16T14:27:45.000Z

Issue not seen since update