Damage and Armor interaction
Bert-Proesmans opened this issue · 2 comments
I was looking at Character::TakeDamage and noticed the damage to inflict first passes armor after which it's bound to the Predamage property.
Shouldn't it be the other way around; Firsts predamage and then reducing the amount of armor?
Related code
It would be an ideal moment to test with Prophet Velen.
Also, Character::TakeHeal doesn't have a pre-heal property. This might also be a case where Prophet Velen would fail.
Shouldn't it be the other way around; Firsts predamage and then reducing the amount of armor?
You're right, but probablly not in the way you think about ... PreDamage is only used for IceBlock ... and of course armor has to be counted in ... and shouldn't be touched if it's a leathal damage ...
Concerning [EX1_350] Prophet Velen, it isn't implemented, at the moment, but that is probably to solve over a tag which sets to double ... like spelldamage ...