Helius/microrl

Wishlist

barthess opened this issue · 3 comments

barthess commented
  1. uncomment line 283 in microrl.c "// print_prompt (this);"
  2. add _FIRST_PROMPT_DEFAULT macro and print it just before first prompt during initialization
Helius commented

Do you mean, that _FIRST_PROMPT_DEFAULT differ from _PROMPT_DEFAULT?
For example, first we print:
"@@*** Super cool device by author, version 1.2.3, for help type help... ***@@", is it?
this is not prompt! You can print it directly at start, after you init your communication module!

I comment 283, because microrl_init calls, before communication subsystem is ready, for example i use USB-CDC class, and it init some time, so i can't print anything. If users print callback not ready to print, it may fault application.
But i can add condition
#ifdef _ENABLE_INIT_PROMPT
print_promt (this);
#endif
user may enable it, if print callback becomes ready fast, like UART.

May be, i don't understand you correctly?

barthess commented

Yes, you understand me correct.
2) I just never thought about manual printing of first a message. Never mind.

  1. It would be nice to have
    #ifdef _ENABLE_INIT_PROMPT
    print_promt (this);
    #endif
    because I call microrl_init after modem startup.
Helius commented

Done, thank you for you interest )