HelpChat/ChatChat

Format tags ignore permission checks

joeyahines opened this issue · 2 comments

It appears that format tags are not respecting permissions associated to that tag.

Test with chathcat.tag.color
Screenshot_20220820_114856

Test with chathcat.tag.bold
image

While debugging it looks like the permission checks are building the resolver correctly, but Minimessage renders the tags anyway.

Interesting. Will look into it right away.

Found the problem. We're not using a custom MiniMessage instance but rather the default one.

? MessageUtils.parseToMiniMessage(message, resolver.build())
: MessageUtils.parseToMiniMessage(message, resolver.build()).replaceText(URL_REPLACER_CONFIG);

Will make a PR with the fix soon.