HenningM/express-ws

Incompatible with node-http-proxy (and http-proxy-middleware)

aral opened this issue · 0 comments

aral commented

Since express-ws modifies the path of incoming WebSocket requests it is incompatible with proxying WebSockets (as other servers do not understand or employ the same naming convention/fake GET route hack).

Going to look into whether the actual modification can be made within middleware that obeys the middleware chain so that it can happen only if the proxy server falls back through to the middleware chain without handling the upgrade itself (e.g., on a 404).