HenryQW/mercury_fulltext

tt-rss php8 error

somedevreally opened this issue · 9 comments

after tt-rss has update to php8 i see this error

E_WARNING (2)	
plugins.local/mercury_fulltext/init.php:218	
Undefined property: stdClass::$content
1. plugins.local/mercury_fulltext/init.php(218): ttrss_error_handler(2, Undefined property: stdClass::$content, plugins.local/mercury_fulltext/init.php, 218)
2. plugins.local/mercury_fulltext/init.php(241): process_article([{"owner_uid":1,"guid":"1,52781401121009","guid_hashed":"{\"ver\":2,\"uid\":1,\"hash\":\"SHA1:1d5db5ad0bc86275e526925c056e86f3b336526a\"}","title":"{redacted})
3. classes/pluginhost.php(198): hook_article_filter([{"owner_uid":1,"guid":"1,52781401121009","guid_hashed":"{\"ver\":2,\"uid\":1,\"hash\":\"SHA1:1d5db5ad0bc86275e526925c056e86f3b336526a\"}","title":"{redacted}.)
4. classes/rssutils.php(818): chain_hooks_callback(hook_article_filter, {Closure}, [{"owner_uid":1,"guid":"1,52781401121009","guid_hashed":"{\"ver\":2,\"uid\":1,\"hash\":\"SHA1:1d5db5ad0bc86275e526925c056e86f3b336526a\"}","title":"{redacted})
5. update.php(238): update_rss_feed(1724, 1)

I do not intend to update this plugin until TTRSS stops committing breaking changes. There have been too many breaking changes, no point in updating it only for it to become incompatible in a few days if not hours.

yes i agree, tt-rss dev has been making changes a lot.
i wanted to bring it to your attention that's plugin is breaking.

for couple of day there was no error, but last few days its giving same error again

Can you post the error log here?

E_WARNING (2)	
plugins.local/mercury_fulltext/init.php:218	
Undefined property: stdClass::$content
1. plugins.local/mercury_fulltext/init.php(218): ttrss_error_handler(2, Undefined property: stdClass::$content, plugins.local/mercury_fulltext/init.php, 218)
2. plugins.local/mercury_fulltext/init.php(241): process_article([{"owner_uid":1,"guid":"1,52781421949505","guid_hashed":"{\"ver\":2,\"uid\":1,\"hash\":\"SHA1:06e2994d8cfa6058d054ae98ad22ddf8f94f63c0\"}","title":"redacted","content":"<ol><...)
3. classes/pluginhost.php(198): hook_article_filter([{"owner_uid":1,"guid":"1,52781421949505","guid_hashed":"{\"ver\":2,\"uid\":1,\"hash\":\"SHA1:06e2994d8cfa6058d054ae98ad22ddf8f94f63c0\"}","title":"redacted","content":"<ol><...)
4. classes/rssutils.php(801): chain_hooks_callback(hook_article_filter, {Closure}, [{"owner_uid":1,"guid":"1,52781421949505","guid_hashed":"{\"ver\":2,\"uid\":1,\"hash\":\"SHA1:06e2994d8cfa6058d054ae98ad22ddf8f94f63c0\"}","title":"redacted","content":"<ol><...)
5. update.php(235): update_rss_feed(1724, 1)

Looks like it's broken again, will have to fix it later

I tested it against the latest build of ttrss, it's working.

i removed the whole folder and added again. just to be sure.
am still getting the errors
so is it just me?

E_WARNING (2) 
plugins.local/mercury_fulltext/init.php:167 
Undefined array key "mercury_fulltext_enabled" 
1. plugins.local/mercury_fulltext/init.php(167): ttrss_error_handler(2, Undefined array key "mercury_fulltext_enabled", plugins.local/mercury_fulltext/init.php, 167) 
2. classes/pluginhost.php(145): hook_prefs_save_feed(1971) 
3. classes/pref/feeds.php(743): run_hooks(hook_prefs_save_feed, 1971) 
4. classes/pref/feeds.php(681): editsaveops() 5. backend.php(133): editSave()
E_WARNING (2)	
plugins.local/mercury_fulltext/init.php:218	
Undefined property: stdClass::$content
1. plugins.local/mercury_fulltext/init.php(218): ttrss_error_handler(2, Undefined property: stdClass::$content, plugins.local/mercury_fulltext/init.php, 218)
2. plugins.local/mercury_fulltext/init.php(241): process_article([{"owner_uid":1,"guid":"1,CBMiT2h0dHBzOi8vdGhlZGlwbG9tYXQuY29tLzIwMjEvMDMvaXNyYWVsLWlyYW4tYW5kLWNoaW5hLXVzLW1pZGRsZS1lYXN0LXJlbGF0aW9ucy_SAQA","guid_hashed":"{\"ver\":2,\"uid\":1,\"hash\":\"SHA1:688592a630a8685b88358b0ecff5e4e4f7c904ee\"}","title":"redacted, ...)
3. classes/pluginhost.php(198): hook_article_filter([{"owner_uid":1,"guid":"1,CBMiT2h0dHBzOi8vdGhlZGlwbG9tYXQuY29tLzIwMjEvMDMvaXNyYWVsLWlyYW4tYW5kLWNoaW5hLXVzLW1pZGRsZS1lYXN0LXJlbGF0aW9ucy_SAQA","guid_hashed":"{\"ver\":2,\"uid\":1,\"hash\":\"SHA1:688592a630a8685b88358b0ecff5e4e4f7c904ee\"}","title":"redacted, ...)
4. classes/rssutils.php(801): chain_hooks_callback(hook_article_filter, {Closure}, [{"owner_uid":1,"guid":"1,CBMiT2h0dHBzOi8vdGhlZGlwbG9tYXQuY29tLzIwMjEvMDMvaXNyYWVsLWlyYW4tYW5kLWNoaW5hLXVzLW1pZGRsZS1lYXN0LXJlbGF0aW9ucy_SAQA","guid_hashed":"{\"ver\":2,\"uid\":1,\"hash\":\"SHA1:688592a630a8685b88358b0ecff5e4e4f7c904ee\"}","title":"redacted, ...)
5. update.php(235): update_rss_feed(928, 1)
Undefined array key "mercury_fulltext_enabled" 

looks like you are configuring per feed, that's something I did not test. When opening an issue you need to provide steps to reproduce it.

Also this plugin is tested to work with the latest build of ttrss, I do not support self-deployment via non-docker way.

See: https://github.com/HenryQW/Awesome-TTRSS