inconsistent crit from luk calculation for base/gear luk and buff-sourced luk
Corylus-a opened this issue · 1 comments
Describe the bug
crit gained from base and gear luk is calculated using the formula st->cri += 10 + (st->luk * 10 / 3) (or around 0.33 per point) in "status_calc_misc"
crit gained from buff bonuses (like gloria or truesight) is calculated using the formula bst->cri + 3*(st->luk - bst->luk) (or 0.3 per point) in "status_calc_bl_main"
To Reproduce
compare the amount of crit gained from the same amount of luk through either buffs or base value
(for values where the difference in rounding would make a difference)
Expected behavior
buffs should use the same formula as base stats,
for example gloria should add 10% crit not 9%, truesight should be 16/1000 not 15/1000
System specs (please complete the following information):
pre-renewal
example a sniper with 25+(6+5) luk from gear will have
10+360/3= 130 crit (showing as 13 on char sheet)
removing 5 luk worth of gear down to 25+6 and adding 5 luk +1 crit rating from true sight level 1
10+310/3= 113 + 5*3=15 total 128 crit (showing still as 12+1 =13 crit rating on sheet)
this bug costs snipers with gloria and true sight 1.1% crit (35 luk downgraded from 116 to 105 or 11/1000 less)