HicServices/RDMP

Plugin load failures silently ignored

jas88 opened this issue · 2 comments

jas88 commented

Describe the bug

If loading a plugin fails, no indication is given.

To Reproduce
Steps to reproduce the behavior:

Try installing RdmpDicom v7.0.0 - it doesn't load, nor is there any diagnostic information to suggest why.

Expected behavior

(a) it should work! (This aspect may be an RdmpDicom issue) - (b) if it fails, it should actually say so with some sort of diagnostics, e.g. backtrace.

Screenshots
If applicable, add screenshots to help explain your problem.

RDMP Version
8.0.7

Error with Stack Trace

No stack trace given - that's the whole problem!

Database Engine
Sql Server, Oracle, MySql or Postgres.

Additional context
Add any other context about the problem here.

Probably not ideal but:

  • For the CLI you can add --logstartup to see plugin errors.
  • For the gui you can click the Startup warning/tick icon next to the progress bar to view the plugin loading status

If a plugin is not compatible with the current version of rdmp it shows up as 'Not Loaded' or 'Old Plugins' in the tables/advanced tree.

Theres actually a good writeup of this in 'Troubleshooting Plugins':

https://github.com/HicServices/RDMP/blob/develop/Documentation/CodeTutorials/PluginWriting.md#troubleshooting-plugins

See also the header 'Other Steps you can take'

For example

dotnet run -- cmd list Plugin --logstartup --dir ./bin/Debug/net6.0/rdmpyaml > log.txt
jas88 commented

Thanks @tznind - it was Terminal.Gui - RdmpDicom was using a newer version than this release of RDMP. Just need to get that feature branch merged in and a new release built.