outputDirectory ignored for '-s'

Question

outputDirectory ignored for '-s'

JorySchossau opened this issue 6 years ago · 11 comments

Should this be supported? How about for '-l' and '-i' etc.?
I'm encountering this because I'm working on testing, and am invoking various mabes from different locations. I can add extra 'cd' commands to work around this problem.

Answer 1 · 2018-05-03T21:42:36.000Z

So -s should save settings files in outputDirectory? and same for .plf files with -l?

What is '-i'?

Answer 2 · 2018-05-03T21:47:27.000Z

I think so, but am also asking. '-i' is generation of buildOptions - not sure about that one.

Answer 3 · 2018-05-03T21:59:38.000Z

The '-i' option is an mbuild.py concern, so that should be a different issue I think. The build system we provide is different than what the mabe executable does.

Answer 4 · 2018-05-03T22:43:59.000Z

So I looked at the code, adn what's easy to do. Right now, it seems that there are 2 options.

We could allow the user to set the output directory for '-s' (.cfg) and '-l' (.plf) file options.
The .cfg and .plf files are saved to the dir indicated by outputDirectoryPL.

Answer 5 · 2018-05-04T02:30:25.000Z

I agree with your comments, and I think option 1 would be best as it seems like something it should do. What are your thoughts between the two?

Answer 6 · 2018-05-04T02:31:39.000Z

If like to hear Cliff's thought too. Added.

Answer 7 · 2018-05-07T14:05:21.000Z

When you run -s or -l without first loading a custom output directory from -f settings.cfg or a -p GLOBAL-outputDirectory, how will mabe know to use anything other than the default output directory?

Answer 8 · 2018-05-07T14:12:47.000Z

Yes, that would be the behavior of MABE. Do you foresee a problem with that?

Answer 9 · 2018-05-07T14:18:20.000Z

Do you foresee a problem with that?

well, there is the potential for any user to overwrite their current settings files with default settings files unintentionally. But that's true even if we are using the output directory in the settings. I think we should either detect that the user is overriding their settings files and warn them with a [y/N] sort of prompt, or we just leave it as is.

Answer 10 · 2018-05-07T14:42:00.000Z

File overwriting conversation moved to #212. That should be resolved first, but deserves its own thread.

Answer 11 · 2018-05-23T14:00:39.000Z

Sorry, I'm very late to the party. I think that -s should save locally, but think that -s [path optional] may be a good option here. In either case, I do not think that we should use the output directory parameter simply because of this case:

a) edit output dir in settings.cfg
b) edit other stuff in settings.cfg
c) update mabe
d) run ./mabe -f settings.cfg -s
e) the user is confused, they loaded the setting file here, but then saved the new setting file to output path...