zip DL on mac fails, requiring git repo w/ commit present

Question

zip DL on mac fails, requiring git repo w/ commit present

Closed this issue 6 years ago · 6 comments

Answer 1 · 2018-09-17T18:43:02.000Z

Can you elaborate on this? It seems to work on mac for me, unless I'm misunderstanding.

Answer 2 · 2018-09-17T18:47:58.000Z

This might be a result of when later we realized the user didn't have the minimum required version of python installed, but maybe you can check this anyway.
Reproduce:
Download MABE zip file from github.
Unzip file.
You now have mabe that knows nothing of github.
Call mbuild as you usually do
mbuild fails, winging about git.

Answer 3 · 2018-09-17T19:08:22.000Z

Oh, I see the issue now! MABE-master.zip installs fine, but MABE-development.zip does complain that there is no .git. Oddly though, with both python 2.7 and python 3.6, the build still succeeds.

Answer 4 · 2018-09-17T19:16:05.000Z

But it doesn't display as an "Error" ?

…

On Mon., 17 Sep. 2018, 15:08 Acacia Ackles, ***@***.***> wrote: Oh, I see the issue now! MABE-master.zip installs fine, but MABE-development.zip does complain that there is no .git. Oddly though, with both python 2.7 and python 3.6, the build still succeeds. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#269 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACjbea6jQOIGPslqC_miWUBMwXWtd14hks5ub_MygaJpZM4WsFKd> .

Answer 5 · 2018-09-17T19:18:18.000Z

It displays as:

fatal: not a git repository (or any of the parent directories): .git

But it isn't actually fatal, as the build proceeds as normal and ./mabe runs TestWorld as usual once build completes.

Answer 6 · 2018-09-17T19:20:25.000Z

Interesting. Thanks for testing! For posterity: That error needs to be swallowed in mbuild so the user doesn't see it.

…

On Mon., 17 Sep. 2018, 15:18 Acacia Ackles, ***@***.***> wrote: It displays as: fatal: not a git repository (or any of the parent directories): .git But it isn't actually fatal, as the build proceeds as normal and ./mabe runs TestWorld as usual once build completes. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#269 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACjbeYePYFrqwVKl0VNYgc3tTo5o9mDZks5ub_V7gaJpZM4WsFKd> .