Hipo/django-sloop

Push Message admin should be fully read only

Closed this issue · 4 comments

ozandogrultan commented

We need to remove device field from readonly_fields in PushMessageAdmin since it is a required field and if it is not populated we get the

null value in column "device_id" violates not-null constraint

error while trying to create a new PushMessage instance.

Code reference: https://github.com/Hipo/django-sloop/blob/master/django_sloop/admin.py#L128

alicertel commented

@ozandogrultan It's designed to be read only in the admin level. You want to create push message object through django admin right?

Alternatively you might try to send push notification which will create push message object.

ozandogrultan commented

Yes, I have discovered this issue while trying to send push messages.

Do you think it would be more clear if we make all fields of PushMessage read-only in the ModelAdmin then? Was there a purpose for making data and sns_response writable?

alicertel commented

Do you think it would be more clear if we make all fields of PushMessage read-only in the ModelAdmin then?

Indeed.

Was there a purpose for making data and sns_response writable?

No, it was not in purpose.

alicertel commented

Maybe we should change the issue as "Push Message admin should be fully read only."

  • 👍1