Hirevo/alexandrie

"The published version is too low" - why is that an error?

Riateche opened this issue · 3 comments

Riateche commented

This error prevents publishing new patches for previous minor versions of the crate. For example, if 0.1.0 and 0.2.0 are published, alexandrie refuses to publish 0.1.1. This is a very common case, and crates.io handles it without issues.

damianwadley commented

Though this issue was reported before #116 fixed it, the fix is incomplete: alexandrie-index's add_record still requires that the new version be lower than the latest. Perhaps it would be best to remove that check entirely and let the calling code decide whether it wants to add or not?

jcgruenhage commented

Aside of whether that should be an error at all: VersionTooLow is duplicated in both alexandrie_index::IndexError and in alexandrie::AlexError. This should be handled in either the API or the index. The problem that #116 doesn't fix this in all the places is caused by this duplication IMO, so in my fix (PR incoming soon) I've fixed that by removing the check from the index.

Hirevo commented

This issue is now fixed thanks to the merging of PR #124 from @jcgruenhage.
Thanks a lot for the contribution and sorry again for my way too long of a delay.