Creating database fails, and tries on wrong server if logged into multiple

Question

Creating database fails, and tries on wrong server if logged into multiple

joachimtingvold opened this issue 4 years ago · 3 comments

PostgreSQL 9.6.15
phpPgAdmin6 on latest master-branch (16b6650)
nginx/1.18.0
php7.3 (7.3.19-1~deb10u1)

Trying to create a database fails with the following error;

strsqlerror
ERROR: zero-length delimited identifier at or near """"

LINE 1: ...t1" WITH TEMPLATE="template1" ENCODING='UTF-8' TABLESPACE ""

^

SQL:
CREATE DATABASE "kek-test1" WITH TEMPLATE="template1" ENCODING='UTF-8' TABLESPACE ""

Additionally, if you are connected to multiple servers, it will attempt to create the database on the server you logged into first.

Log into server1
Log into server2
Try to create database on server2
The creation fails, but shows that it tried to create it on server1

Answer 1 · 2020-09-09T12:38:17.000Z

Video showing the issue (including issue #333 and #335): https://files.jocke.no/debug/phppgadmin6-issues_20200909.mov

Answer 2 · 2020-09-09T12:39:48.000Z

Not the best comparison, but this works fine using phpPgAdmin v6.0.0-b28 on PostgreSQL 9.6.10.

Answer 3 · 2020-10-19T18:24:57.000Z

I see... this one has the same origin 2b72a65
having the collation , encoding and namespace not set, it shouldn't be using those parameters, but it was comparing empty strings with nulls, therefore there wasn't strict equality .

I'm releasing the fix as v.6.1.2