Multi-threading window in oauth.py for guest action
Opened this issue · 2 comments
sebbASF commented
There is a multi-threading window in the following code:
Lines 69 to 83 in ee93bf6
If there are any context switches between the check for the code and deleting it, the same code can potentially be used twice.
Far safer to try to pop the code from the invites.
Humbedooh commented
There shouldn't be any context switches as it's single-threaded with no awaits in that bit.
sebbASF commented
At the moment. But it's better to play safe from the start.