IATI/IATI-Standard-SSOT

Unable to checkout 'bc1b8b1f' in submodule path 'IATI-Extra-Documentation'

andylolz opened this issue · 4 comments

andylolz commented

Did someone force-push to the IATI-Extra-Documentation repo? <-- UPDATE: I think this is unlikely. I think the cause is more likely a result of the problem described in #168.

The commit hashes for the IATI-Extra-Documentation repo referenced on the version-2.03 branch (IATI/IATI-Extra-Documentation@bc1b8b1) and version-2.02 branch are a) the same, and b) missing… So the SSOT repo can’t be cloned or updated without error.

Steps to reproduce:

  1. Clone this repo: 
    git clone --recursive https://github.com/IATI/IATI-Standard-SSOT.git
  2. See the following: 
    Cloning into 'IATI-Standard-SSOT'...
remote: Counting objects: 1704, done.
remote: Compressing objects: 100% (53/53), done.
remote: Total 1704 (delta 26), reused 16 (delta 5), pack-reused 1646
Receiving objects: 100% (1704/1704), 344.96 KiB | 62.00 KiB/s, done.
Resolving deltas: 100% (989/989), done.
Checking connectivity... done.
Submodule 'IATI-Codelists' (https://github.com/IATI/IATI-Codelists.git) registered for path 'IATI-Codelists'
Submodule 'IATI-Extra-Documentation' (https://github.com/IATI/IATI-Extra-Documentation.git) registered for path 'IATI-Extra-Documentation'
Submodule 'IATI-Rulesets' (https://github.com/IATI/IATI-Rulesets.git) registered for path 'IATI-Rulesets'
Submodule 'IATI-Schemas' (https://github.com/IATI/IATI-Schemas.git) registered for path 'IATI-Schemas'
Cloning into 'IATI-Codelists'...
remote: Counting objects: 1273, done.
remote: Compressing objects: 100% (12/12), done.
remote: Total 1273 (delta 2), reused 11 (delta 2), pack-reused 1259
Receiving objects: 100% (1273/1273), 311.00 KiB | 57.00 KiB/s, done.
Resolving deltas: 100% (893/893), done.
Checking connectivity... done.
Submodule path 'IATI-Codelists': checked out 'a1f0f29010a827c54026ef000cad5d740b2b9471'
Cloning into 'IATI-Extra-Documentation'...
remote: Counting objects: 8053, done.
remote: Compressing objects: 100% (13/13), done.
remote: Total 8053 (delta 3), reused 0 (delta 0), pack-reused 8040
Receiving objects: 100% (8053/8053), 1.10 MiB | 67.00 KiB/s, done.
Resolving deltas: 100% (5404/5404), done.
Checking connectivity... done.
fatal: reference is not a tree: bc1b8b1f1dc5c7e4e3d47af1d482ee728559b174
Cloning into 'IATI-Rulesets'...
remote: Counting objects: 552, done.
remote: Total 552 (delta 0), reused 0 (delta 0), pack-reused 551
Receiving objects: 100% (552/552), 98.14 KiB | 58.00 KiB/s, done.
Resolving deltas: 100% (310/310), done.
Checking connectivity... done.
Submodule path 'IATI-Rulesets': checked out 'e77e6860ceba3be71d95c7ed95b9c78f3f29928e'
Cloning into 'IATI-Schemas'...
remote: Counting objects: 5952, done.
remote: Compressing objects: 100% (41/41), done.
remote: Total 5952 (delta 25), reused 16 (delta 7), pack-reused 5904
Receiving objects: 100% (5952/5952), 1.67 MiB | 82.00 KiB/s, done.
Resolving deltas: 100% (4124/4124), done.
Checking connectivity... done.
Submodule path 'IATI-Schemas': checked out '5dd9ffba76aff6629d88ef8d6c960c3cc7fbf536'
Unable to checkout 'bc1b8b1f1dc5c7e4e3d47af1d482ee728559b174' in submodule path 'IATI-Extra-Documentation'
andylolz commented

I don’t know, but I expect #140 might help mitigate these sorts of problems.

andylolz commented

The commit hash for IATI-Rulesets on the version-2.02 branch (IATI/IATI-Rulesets@f8ff550) is also wrong, and while the commit referenced does exist, it's out of date and in fact the build was broken at that point :(

andylolz commented

I looked into this a bit more, and I think it was caused by a combination of:

  • local commits to submodule repos
  • the update_submodules.sh script not dealing with the above (see #168)
  • lack of CI on this repo (E.g. Travis could be made to check the site actually builds) (see #170)
  • lack of testing during the review process (#159 was approved, but I suspect it didn’t work)
  • 👍1
andylolz commented

git clone --recursive now succeeds without error, so I’ll close this issue.