Enhance Travis-CI test to verify that the docker build completes successfully

Question

Enhance Travis-CI test to verify that the docker build completes successfully

Closed this issue 5 years ago · 7 comments

ptitzler commented 5 years ago

This test should be performed after flake8 testing.

Answer 1 · 2020-04-21T21:05:39.000Z

#20
Already finished docker build. Please see the PR here.

Answer 2 · 2020-04-21T21:37:40.000Z

@ptitzler I think that if the docker build fails then everything will fail. I will verify this with a test PR

Answer 3 · 2020-04-21T21:38:59.000Z

Thank you Brendan @bdwyer2

Answer 4 · 2020-04-21T22:12:19.000Z

@ptitzler does PR #21 satisfy you or do you want further testing?

Answer 5 · 2020-04-22T14:09:07.000Z

In #20 this line

- docker run -it -d -p 5000:5000 max-question-answering-web-app

is incorrect because port 5000 is not exposed:

https://github.com/IBM/MAX-Question-Answering-Web-App/blob/master/Dockerfile#L23

In general I believe it would have been better to run the docker build after flake 8 (in the scripts section). The motivation is that the source code must be syntactically error free before one would attempt to package it. But I guess one that doesn't change the outcome materially.

Answer 6 · 2020-04-22T17:43:08.000Z

We can change add docker ps | grep max-question-answering-web-app to the script section and move flake8 to the build section

Answer 7 · 2020-04-22T21:34:01.000Z

Create another PR based on Patrick and Brendan's comments. Thank you for helping me!
#22