IBMStockTrader/messaging

Externalize the URL through kubernetes secret

vikramkhatri opened this issue · 1 comments

Can you please externalize the host in this URL so that we can customize it though kubectl secret.

private static final String NOTIFICATION_SERVICE = "http://notification-service:9080/notification";

The issue with the URL is that the host name is notification-service, which is hard coded and will break if yaml file is changed for defining the service.

The second issue is that if MQ is in a separate namespace then the host must be notification-service/<namespaceName>/svc/cluster.local

In my case, this is not working since my MQ is in default namespace and this service is in stock-trader namespace.

Thanks.

I delivered this about a year ago in my umbrella helm chart for Stock Trader, and last month in my umbrella OpenShift operator (that embeds the helm chart). Sorry I forgot to close out this issue then.

image

image