Uniform unit test suit
cbonesana opened this issue · 1 comments
cbonesana commented
The tests requires both junit:4.12 and junit-jupiter-params:5.4.2.
Junit4 is used for all tests, while Jupiter is used only for some parametric tests. It would be nice to use only one version of Junit. Given the requirement for parametric tests, I suggest to switch to use Junit5.
In addition, personally prefer to throw IllegalArgumentException for sanity checks and not user a unit asserts from a test framework like Junit (example UAIParser.java#L123 and subclasses).