IFTTT/JazzHands

Overriding scrollViewDidScroll in README.md

pbrewczynski opened this issue · 1 comments

It think you haven't updated README.md to accommodate new changes in your library since you suggest to override

- (void)scrollViewDidScroll:(UIScrollView *)aScrollView

with the content

[self.animator animate:scrollView.contentOffset.x];

but the same thing is in your base method (and some other stuff), so you don't need to call it yourself.

Additionally you don't suggest to call superclass (which I've suggested in the pull request), what couse, interface useless, since the _isAtEnd is changed in this callback!

self.isAtEnd = (aScrollView.contentOffset.x >= IFTTTMaxContentOffsetXForScrollView(aScrollView));

If refer to that part :

"Now, to animate the view, tell the animator what time it is. For example, to tie this animation to a UIScrollView, notify the animator of time in the scroller's delegate method.

(void)scrollViewDidScroll:(UIScrollView *)scrollView
{
[self.animator animate:scrollView.contentOffset.x];
}
This will produce an effect where the view will be at 10,10 and sized 100x100 for scroll positions 0 to 30. Between scroll positions 30 and 60, the view will grow and move until scroll position 61, where it will be locked to 150, 10 and 200x200."

but the same thing is in your base method (and some other stuff), so you don't need to call it yourself.

This is true only if you're using IFTTTAnimatedScrollViewController, which is just a simple wrapper around a scroll view. If you're animating your own UIScrollView with Jazz Hands, you'll still need to tell the animator what time it is. I think that might be where the confusion lies?