IIIF/trc

Recipe 40: Image Rotation Two Ways

Opened this issue · 6 comments

glenrobson commented

Links

Background and Summary

This is a recipe that has come up frequently in the IIIF online training course where participants would like to rotate a IIIF image in a manifest so it is in its correct orientation without replacing the original image. There are two ways to achieve this, either using an ImageAPISelector or via CSS. Both of these methods are discussed in this recipe.

There are currently no viewer implementations of this functionality.

Voting and changes

We welcome comments on the recipe and as well as voting +1, confused face or -1 feel free to add comments to this issue. If this issue is approved then the author will take account of the comments before we merge the branch in to the master cookbook branch.

If the recipe is rejected by the TRC then we will make the changes requested and resubmit it to a future TRC meeting. If you feel that your comments are substantial enough that the recipe should be looked at again by the TRC after the changes have been made please vote -1 (thumbs down). A confused face is treated as abstaining.

Changes to the recipe will only be made after the TRC voting process has concluded.

glenrobson commented

From TRC:

"There is an little typo, in the second paragraph of section 'Image service'.
At "...what your image servers supports and...', 'servers' should be 'server'"

robcast commented

👍 with a few small suggestions (also as hypothes.is annotations on the preview)

  • "This section" (last sentence in section "Cascading Style Sheets (CSS)"): Does this refer to the Prezi spec or this recipe? If it refers to this recipe maybe "this recipe" or "the following section"?
  • section "Example 2: CSS": Also mention the class ".rotated" in the CSS and the matching styleClass property on the body?
  • "CSSStylesheet" in example 2 JSON: WebAnno spec uses CamelCase CssStylesheet
kirschbombe commented

👍 with a few suggestions in hypothes.is

  • Would it make more sense to switch the order of the first two paragraphs in the Image Service section?
  • The last paragraph/sentence of the Image Service section seems unnecessary, but it's also a bit awkward to read and could be revised.
triplingual commented

Noting my 👍🏻 for my own recipe, as I do. Tx to @glenrobson for presenting in my absence and to @robcast and @kirschbombe for the suggestions.

triplingual commented

(Also, #noteToSelf, comment from @stephenwf at the PR itself)

glenrobson commented

Issue 90 (Recipe 40: Image Rotation Two Ways)

+1: 23 [akrishnan15 dlpierce eliotjordan glenrobson hadro irv jpadfield jtweed julsraemy kirschbombe ksclarke markpatton mikeapp mixterj mposton-folger nfreire omaeazusa regisrob rentonsa shuddles thehabes tpendragon triplingual]
0: 0 []
-1: 0 []
Not TRC: 0 []
Ineligible: 0 []

Result: 23 / 23 = 1.00

Super majority is in favor, issue is approved