IMSMWU/RClickhouse

Naming convention for name of database

Closed this issue · 3 comments

jakejh commented

In most of the other DBI-compliant interfaces I'm aware of, the name of the database is specified by an argument called dbname, not db. See RPostgres, RMariaDB, and RSQLite. Would you consider following this convention? Thanks for making this package available to the community.

RClickhouse/R/ClickhouseDriver.R

Line 145 in 65c04ff

#' @param db name of the default database.

dwinkler1 commented

For me this would be fine. I'll prepare a PR

  • 👍1
jakejh commented

Thanks!

inkrement commented

should be resolved now.