INRIA/scikit-learn-mooc

slides-ci workflow failure

lesteve opened this issue · 3 comments

lesteve commented

Seems like a node dependency issue: https://github.com/INRIA/scikit-learn-mooc/actions/runs/3410391128/jobs/5673295661

I would be in favour of removing this workflow. I am not quite sure why it is useful and what it is supposed to test:

  • what is the Makefile actually testing, that remarker can produce a html, but it probably does not guarantee anything whether the slides looks good or not.
  • do we care about PDF slides? I don't think we use them for the MOOC but maybe I am wrong ...

We should also remove the instructions with remarker in the README or at least we should explain why this is needed ... I never used them personally.

lesteve commented

cc @brospars in case he remembers why the slides-ci workflow was useful

brospars commented

I think it's a relic from : lesteve/scikit-learn-tutorial#22 but it's not used anymore.

lesteve commented

OK thanks, in 59e27ab I removed the workflow and also slides/Makefile and related things, since I don't think this is used anymore.