Unexpected exit behavior for verify and publish tasks

[solarmosaic-kflorence]

The verify and publish tasks use sys.exit(0) on success, and sys.exit(1) on failure. This works fine when you run the command in isolation (e.g. sbt pactPublish), but if you try to run them as part of a sequence of events, either with addCommandAlias or Def.sequential, the sys.exit causes the process to end without running subsequent tasks. For example:

addCommandAlias("publishAll", ";pactPublish;publish;publishEcr")

Will only run pactPublish and then exit, even on success. Using sys.exit(1) on failure seems fine, but on success sys.exit should not be used at all.

See:

• scala-pact/sbt-scalapact-shared/src/main/scala/com/itv/scalapact/plugin/shared/ScalaPactPublishCommand.scala

  Line 65 in 85978df

  private def exitSuccess(): Unit = sys.exit(0)

• scala-pact/sbt-scalapact-shared/src/main/scala/com/itv/scalapact/plugin/shared/ScalaPactVerifyCommand.scala

  Line 77 in 7e1ef12

  if (successfullyVerified) sys.exit(0) else sys.exit(1)