Icinga/ansible-collection-icinga

Display proper fail messages if OS not supported

johanneskastl opened this issue · 3 comments

johanneskastl commented

Is it intentional that there is no install_on_suse.yml file in the icinga.icinga.icingadb_redis role?

https://github.com/Icinga/ansible-collection-icinga/blob/main/roles/icingadb_redis/tasks/main.yml#L15

- name: Include OS specific installation
  ansible.builtin.include_tasks: "install_on_{{ ansible_os_family | lower }}.yml"

If so, the role should fail and report, that the installation on SUSE/openSUSE is not (yet) supported.

mkayontour commented

This is not intentional, but yes we should at least state that the current os is not supported. And don't let it fail completely.
I haven't got the time and resources yet to implement it! If possible you can create a PR, we are grateful for any contribution :)

martialblog commented

The supported platforms are stated in the metadata:

  platforms:
    - name: EL
      versions: ['7']
    - name: Debian
      versions: ['buster','bullseye']
    - name: Ubuntu
      versions: ['jammy']

Unfortunately Ansible doesn't show you that on execution.

johanneskastl commented

This is not intentional, but yes we should at least state that the current os is not supported. And don't let it fail completely. I haven't got the time and resources yet to implement it! If possible you can create a PR, we are grateful for any contribution :)

Thanks for the fast reply. I'll see if I can implement this.