Wrong error log message when assertion signature verification fails
amit12297 opened this issue · 0 comments
amit12297 commented
Code Version
7.4.2
Expected Behavior
When assertion signature verification fails, error log should state "incorrectly_signed_response"
Current Behavior
When assertion signature verification fails, error log states "correctly_signed_response" at response.py (line number - 794)
This creates confusion
Possible Solution
-
Change the error log message to "incorrectly_signed_response"
-
Modify test_false_sign in test_41_response.py to assert correct error message was logged
Steps to Reproduce
- Run :
pytest --log-cli-level=ERROR -v tests/test_41_response.py::TestResponse::test_false_sign
- Observe the last error log, it says "correctly_signed_response"
![Screenshot 2023-08-08 at 2 29 40 AM](https://private-user-images.githubusercontent.com/37745353/258925088-87c9e0cb-161e-4b55-9e77-31eefca1417c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUyNzU2MTUsIm5iZiI6MTcyNTI3NTMxNSwicGF0aCI6Ii8zNzc0NTM1My8yNTg5MjUwODgtODdjOWUwY2ItMTYxZS00YjU1LTllNzctMzFlZWZjYTE0MTdjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTAyVDExMDgzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEwZWI4YTEyMzc4YjZhMTNmNWI3YzIwZWY2MWNmNmZiOGUyNmM4ZTk4YzEwZTViNGQ2NjZmN2ViZTkxMGY2NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.eSndyMUVaAWJ3ytmnt1EFf9GzpKwaOGQ3hwp7T4D7tU)