Fix: wallet api bugs

[hhstore]

Fix wallet api bugs:

• First of all, thank you so much for this project, I'm using it and the experience is great.
• I just needed to use the wallet related api, and found that this part is still under development.
  • https://github.com/Igosuki/binance-rs-async/tree/wallet_api
• I used the master branch and found that some apis are not finished yet, and some have simple bugs.
• So, I can't wait and intend to assist you in getting it done together. 😄
• My fork is here:
  • https://github.com/better-rs/binance-rs-async/tree/dev/wallet-api
• I will continue to update this fork, and then PR to you.

PR(WIP) here:

• #36
• I have fixed some issues, others are still in progress.
• Still under development, no need to merge for now.

[Igosuki]

Hi @hhstore, thank you for bringing this up, I implemented all the endpoints following the docs but didn't test them individually (lack of time).
Let me know when you are finished and we can do a release.

[hhstore]

Hi @hhstore, thank you for bringing this up, I implemented all the endpoints following the docs but didn't test them individually (lack of time). Let me know when you are finished and we can do a release.

• OK. I am still developing.
• The fixes that have been submitted are all tested.
• I'll let you know when I finish the main part of the wallet api.

[Igosuki]

I'm ok with adding utility methods, just make it clear in doc strings that it does more than calling an endpoint.

[hhstore]

I'm ok with adding utility methods, just make it clear in doc strings that it does more than calling an endpoint (端点) .

• Ok.
• 2 utility methods, I will update comments + use cases. (unit tests will also be updated)
• I will give more detailed comments on the newly added 2 APIs(deposit/withdraw history API).
• The official deposit/withdraw history API is very inconvenient to use.
• Need me to add an example return value structure of the new API to the API doc?

[hhstore]

update:

• https://github.com/Igosuki/binance-rs-async/pull/36/files#diff-4007187965c1fea4fd252a76f5f1007b2ea59f6d86e2f454edee547c5036be24R110
• https://github.com/Igosuki/binance-rs-async/pull/36/files#diff-4db9c4cca2ff80c2ad80cbf7111959e148b31ee24cb354f8620c417047fe7b46R161
• Latest commit, renamed utility methods, improved some annotations and unit tests.

[Igosuki]

If we are returning a struct, just point to that

…

On Sat, Jun 18, 2022, 01:00 Henry.Huang ***@***.***> wrote: I'm ok with adding utility methods, just make it clear in doc strings that it does more than calling an endpoint (端点) . - Ok. I will give more detailed comments on the newly added 2 APIs(deposit/withdraw history API). - The official deposit/withdraw history API is very inconvenient to use. - Need me to add an example return value structure of the new API to the API doc? — Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADDFBUVAU7LZET7P65FQG3VPT7SVANCNFSM5YLOSCVQ> . You are receiving this because you commented.Message ID: ***@***.***>

[hhstore]

• Hi @Igosuki
• I have done all the APIs fixes and tests.
• #36
• You can review the codes. This PR is ready to be merged.

[Igosuki]

Thanks a lot, I will add you to contributions.

…

On Wed, Jun 22, 2022, 07:30 Henry.Huang ***@***.***> wrote: - Hi @Igosuki <https://github.com/Igosuki> - I have done all the APIs fixes and tests. - #36 <#36> - You can review the codes. This PR is ready to be merged. — Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADDFBRGIXTV67IZAIZH4LLVQKQI3ANCNFSM5YLOSCVQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Igosuki]

@hhstore Are you ok if I change your PR a bit for API consistency purposes ?

[hhstore]

@hhstore Are you ok if I change your PR a bit for API consistency purposes ?

• No problem, feel free to modify it.

[Igosuki]

I cleaned up the PR and merged from another branch

[hhstore]

that's great.