Indigosoft/ngxd

Angular 9 & OnPush

Closed this issue ยท 12 comments

Hi,

Just upgrade to Angular 9 and seems to be that the library doesn't work when all components are OnPush. Any ideas on how to fix this ?

Hi @JETiCODEV,

thanks for the issue. Could you please reproduce your problem and put the link here?

I pulled the ngxd source into our project and made a quick change, seems to be that adding this line to attachContextPropertyToComponentInput "solves" it:

image

@JETiCODEV thanks! I'll check it and publish new release ASAP.

@thekiba seems to be that when running it in stackblitz it just works, but I tried to run it locally (fresh Angular setup) and there it doesn't work ...

Seems that I shared the wrong stackblitz https://stackblitz.com/edit/angular-9-0-0-rc-1-wn3nvu?file=src/app/app.module.ts

Seems to be that works in Stackblitz, but not in a fresh angular project. So I pushed the changes into a test repo, hope that will help. This is the working version, if you want to play around better to revert the mentioned change.

https://github.com/JETiCODEV/test

I published new version v9.0.1, try to check this

Great, thanks! Will give it a try.

Just tried to add the new library to my existing project but it results in the following error:
image

So sorry, I forgot to build for a ViewEngine ๐Ÿ˜… Now it's should be works, please use v9.0.2 ๐Ÿ™

Great, it's working ! Thanks for the effort, btw this library is really great in combination with Angular 9 ! Keep up to good work !

Yeah, thanks ๐Ÿ˜ With Angular 9 is really powerful, check this some use cases with lazily components and resolve pipe https://twitter.com/thekiba_io/status/1230076631722659841?s=20