Mvemba a Nzinga's LA doesn't benefit from a religion more than any other civ would

[Infixo]

From Matso_Kai (Steam)
Mvemba a Nzinga's leader ability, Religious Convert, is bugged. You don't benefit from a religion more than any other civ would. This has been reported in multiple forums. The BBG mod seems to have fixed this, but it would be great to have this working in a vanilla game.

[Infixo]

BBG has the code as below. It basically changes "player founded religion" reqset into "player founded religion OR is Mvemba". So yes, all beliefs should be available to Mvemba. But how does the game know which beliefs actually should trigger?

--5.1 Founder Belief Bug Fix
INSERT INTO Requirements(RequirementId, RequirementType) VALUES
	('BBG_REQUIRES_PLAYER_IS_RELIGIOUS_CONVERT', 'REQUIREMENT_PLAYER_LEADER_TYPE_MATCHES'),
	('BBG_REQUIRES_PLAYER_FOUNDED_RELIGION_OR_MVEMBA', 'REQUIREMENT_REQUIREMENTSET_IS_MET');

INSERT INTO RequirementSets(RequirementSetId, RequirementSetType) VALUES
	('BBG_REQSET_FOUNDER_OR_MVEMBA', 'REQUIREMENTSET_TEST_ANY');

INSERT INTO RequirementSetRequirements(RequirementSetId, RequirementId) VALUES
	('BBG_REQSET_FOUNDER_OR_MVEMBA', 'REQUIRES_PLAYER_FOUNDED_RELIGION'),
	('BBG_REQSET_FOUNDER_OR_MVEMBA', 'BBG_REQUIRES_PLAYER_IS_RELIGIOUS_CONVERT');

INSERT INTO RequirementArguments(RequirementId, Name, Value) VALUES
	('BBG_REQUIRES_PLAYER_IS_RELIGIOUS_CONVERT', 'LeaderType', 'LEADER_MVEMBA'),
	('BBG_REQUIRES_PLAYER_FOUNDED_RELIGION_OR_MVEMBA', 'RequirementSetId', 'BBG_REQSET_FOUNDER_OR_MVEMBA');

UPDATE RequirementSetRequirements SET RequirementId = 'BBG_REQUIRES_PLAYER_FOUNDED_RELIGION_OR_MVEMBA' WHERE RequirementId = 'REQUIRES_PLAYER_FOUNDED_RELIGION' AND RequirementSetId <> 'BBG_REQSET_FOUNDER_OR_MVEMBA';

Edit 15.06 This code is only partially good. It works when the religion is adopted, but the problem is when another religion erradicates the first one - the effects from the first one stay.

[Infixo]

SubjectRequirementSetId = 'PLAYER_FOUNDED_RELIGION_REQUIREMENTS' (test all: REQUIRES_PLAYER_FOUNDED_RELIGION)

• BURIAL_GROUNDS_CULTURE_BOMB_TRIGGER_HOLY_SITE
• CHURCH_PROPERTY_GOLD_CITY
• CROSS_CULTURAL_DIALOGUE_SCIENCE_FOREIGN_FOLLOWER
• HOLY_ORDER_APOSTLE_DISCOUNT
• HOLY_ORDER_MISSIONARY_DISCOUNT
• LAY_MINISTRY_CULTURE_DISTRICTS
• LAY_MINISTRY_FAITH_DISTRICTS
• MISSIONARY_ZEAL_IGNORE_TERRAIN
• PILGRIMAGE_FAITH_FOREIGN_CITY
• STEWARDSHIP_GOLD_DISTRICTS
• STEWARDSHIP_SCIENCE_DISTRICTS
• TITHE_GOLD_FOLLOWER
• WORLD_CHURCH_CULTURE_FOREIGN_FOLLOWER

SubjectRequirementSetId != 'PLAYER_FOUNDED_RELIGION_REQUIREMENTS'

• DEFENDER_OF_FAITH_COMBAT_BONUS => DEFENDER_OF_FAITH_REQUIREMENTS (enh) => REQUIRES_PLAYER_FOUNDED_RELIGION
• JUST_WAR_COMBAT_BONUS => JUST_WAR_REQUIREMENTS (enh) => REQUIRES_PLAYER_FOUNDED_RELIGION

NULL

• ITINERANT_PREACHERS_SPREAD_DISTANCE (enh)
• MONASTIC_ISOLATION_REDUCE_COMBAT_LOSS (enh)
• RELIGIOUS_COLONIZATION_AUTO_SPREAD (enh)
• RELIGIOUS_UNITY_ENVOY_ON_ADOPTION (founder)
• SCRIPTURE_SPEAD_STRENGTH (enh)