Ingenico-ePayments/connect-sdk-nodejs

CancelApproval.js

Closed this issue · 9 comments

lkzwieder commented

You are calling cancelapproval but your files are named CancelApproval..

I'm pretty sure you are using Windows and it works for you because in windows lowercase or uppercase it is the same, is not the same in Linux.

cancelapproval
cancelapproval2

lkzwieder commented

The same occurs with ApproveSepaDirectdebit

lkzwieder commented

with Cards in riskassessments

lkzwieder commented

in Bankaccounts

lkzwieder commented

-.-

And there are a lot of similar files through all the app... I bet you are a JAVA developer..

  • 😄1
ebomcke-ingenico commented

Good find, we'll check the entire repo and fix this issue.

  • 👍1
lkzwieder commented

Thanks!!, can I fork and suggest you (via pull request) some modifications? If you allow me I will do that after I finish the implementation?

ebomcke-ingenico commented

Of course, you're welcome to do this. We'll review the suggested changes and update the code generation tools if needed to include them.
Btw, if you're at Money2020 come and see us, we'd love to meet you in person ! Plus we still have loads of water bottles :)

lkzwieder commented

Sadly I'm in Buenos Aires working on saturday night... I want to finish my 'garage company' as soon as possible. =)

ebomcke-ingenico commented

Haha, too bad then. Good luck, we'll be online for the next 16h or so as there's a hackathon going on so feel free to get in touch if you have other issues.