Replace ureq with attohttpc

Question

Replace ureq with attohttpc

Closed this issue 3 years ago · 4 comments

As discussed here using attohttpc could be a viable repalcement for ureq.

Answer 1 · 2021-08-30T12:40:01.000Z

The same person also mentioned ureq should work fine for api.listenbrainz.org, but I'd have to investigate that. ureq might still break for other hosts though, so maybe attohttpc is the best option regardless.

Thoughts?

Answer 2 · 2021-08-30T13:47:09.000Z

Hm. I'm not sure myself but as ureq works on api.listenbrainz.org, we don't know for sure that it'll work on alternative hosts. So, we either do more investigations with ureq and alternate hosts, or we switch to attohttpc completely and bypass proper testing.

Answer 3 · 2021-08-30T14:14:50.000Z

I say we go with attohttpc then.

Answer 4 · 2021-08-30T15:33:02.000Z

OK, so we'll have to rewrite the agent calls in raw/client.rs module. Can I leave that to you? Once that's done, there shouldn't be any other usages of ureq, as the crate abstracts over the client.