Minor CSS issues when using withBasicStyles - hr, blockquote, and ol
Closed this issue · 5 comments
- Package Version: 3.2.0
- Nova Version: 4.3.15
- PHP Version: 8.3.x
Description:
There's some minor CSS issues when rendering HTML/Markdown usng the withBasicStyles
options: Horizontal rules have no margin so they stack on top of each other, Blockquotes don't indent, and ordered lists have no numbering.
![Screenshot 2024-03-12 at 09 46 32](https://private-user-images.githubusercontent.com/1577895/312027674-60c1f008-783d-48dd-ab26-d567fbff2e26.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ5MDE1NTcsIm5iZiI6MTcyNDkwMTI1NywicGF0aCI6Ii8xNTc3ODk1LzMxMjAyNzY3NC02MGMxZjAwOC03ODNkLTQ4ZGQtYWIyNi1kNTY3ZmJmZjJlMjYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjlUMDMxNDE3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTdiM2RhNjg1NTI3MDg5YWVmZTQyOGQ4Y2Y2NjFiYTMwNWI3MmQwY2MyMWIxY2VlYTg4MDczMmYxN2M0MmZhOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.ROWSjk5JyVBJ3jjEIUGLyGU694ci3vJKddDbFPj0XCA)
![Screenshot 2024-03-12 at 09 46 58](https://private-user-images.githubusercontent.com/1577895/312027689-3d5b9544-3a71-4a66-9bd5-d13057007cb0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ5MDE1NTcsIm5iZiI6MTcyNDkwMTI1NywicGF0aCI6Ii8xNTc3ODk1LzMxMjAyNzY4OS0zZDViOTU0NC0zYTcxLTRhNjYtOWJkNS1kMTMwNTcwMDdjYjAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjlUMDMxNDE3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDlhMDlkY2YyYTM4ODZkYjQ1YjE4NThmZjc0ZjIyM2JhYjQyNWNjMzI2N2ZlOGFjN2Q5YTA5ODQwZTY0OGUyYSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.2Uolo7MNngQyjLkFjZR2F1HmjyAGt5Ki8dveu0uksiQ)
![Screenshot 2024-03-12 at 09 46 47](https://private-user-images.githubusercontent.com/1577895/312027681-ef56529f-4b44-4a59-ac0e-6288f2a96f7b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ5MDE1NTcsIm5iZiI6MTcyNDkwMTI1NywicGF0aCI6Ii8xNTc3ODk1LzMxMjAyNzY4MS1lZjU2NTI5Zi00YjQ0LTRhNTktYWMwZS02Mjg4ZjJhOTZmN2IucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjlUMDMxNDE3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzlmODVmNDE3NmNmZmZlOGNkOTNkNGI2Y2NjOTY3ODYzNGE1Y2ZhOWRkNDM4YjhmMGVlMzlhZjk3Y2NlMjA5MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.VydcX14HXvWxgo6JPnmT_j13fcWTVsBeOj5SsbKblNc)
Steps To Reproduce:
Here's some example markdown that will generate the screenshots above.
## Horizontal Rules
___
---
***
## Blockquotes
> Blockquotes can also be nested...
>> ...by using additional greater-than signs right next to each other...
> > > ...or with spaces between arrows.
Ordered
1. Lorem ipsum dolor sit amet
2. Consectetur adipiscing elit
3. Integer molestie lorem at massa
1. You can use sequential numbers...
1. ...or keep all the numbers as `1.`
Start numbering with offset:
57. foo
1. bar
Happy to raise a little PR to address these issues.
Hey @bluec
Nova Version: 4.3.15
Just out of curiosity, why do you use such an old Nova version (and new PHP version at the same time)? Your answer may help me to understand the requirements for our Nova packages.
And thank you for your PR!
Hey @bluec
Nova Version: 4.3.15
Just out of curiosity, why do you use such an old Nova version (and new PHP version at the same time)? Your answer may help me to understand the requirements for our Nova packages.
And thank you for your PR!
I think you have misread or misunderstood. That version of Nova was released less than 3 weeks ago: https://nova.laravel.com/releases