Usage of `assert`s
lehins opened this issue · 1 comments
There are a few places in KES implementation where Control.Exception.assert
is being used. This has no affect since assert
s will never get triggered, because they are removed by the compiler, unless compiled with either -O0
or -fno-ignore-asserts
, which is never the case in this repo.
So, we need figure out whats the purpose of those asserts and either remove them in favor of some other mode of failure or make them count with a cabal flag or something. A good example on how latter can be achieved is in the consensus repo.
This is kind of how asserts are supposed to work, but IMO it's a good idea to just enable them (-fno-ignore-asserts
) - at the very least for testing, but I think it won't hurt to turn them on in production, too.