Change `OneEraGenTxId` to just wrap a `ShortByteString`
amesgen opened this issue · 0 comments
amesgen commented
Currently, OneEraGenTxId
(used for the HFC's GenTxId
) is an n-ary sum:
Since #1017, motivated by #1009, we already compare these based on the underlying hash, ignoring the index of the n-ary sum:
As mentioned in #1009 (comment), the logical next step is to change
OneEraGenTxId
to
newtype OneEraGenTxId xs = OneEraGenTxId { getOneEraGenTxId :: ShortByteString }
to get rid of the n-ary sum completely.
This will require changes to the serialization format, and we will need to keep compatibility with the previous format for some time (it might be fine to not do this for Byron).