InverterNetwork/contracts

Security Review #350 : Exclude BC fee from balances

Closed this issue · 0 comments

This issue is linked to

  • Security Review with PR #350

Explanation

The current implementation does not exclude the collected fee from the balances. This behaviour results in the balances not tracking the real in and outflow of collateral/issuance tokens, creating unwanted behaviour. The decision was made to exclude the fee from the virtual balances as they get updated, as well as track the fee in a separate state within the implementation contract

Category:

  • Low severity / Information issue

Link to review comments