IreneKnapp/direct-sqlite

Update to sqlite 3.8.x

Closed this issue · 8 comments

It looks like sqlite 3.8.x offers some substantial performance improvements due to the new query planner. I'd love to take advantage of that in direct-sqlite.

Sure! I'll get to this hopefully over the weekend. (It's mostly trivial, but I don't have a lot of time...) Feel free to poke me if you haven't heard back by Monday.

Thanks so much!

Consider this a gentle poke. =)

@IreneKnapp Poking once again.

What are the steps involved here? Maybe I can help. Is it just copying in a new sqlite3.c and sqlite3.h and making sure everything still compiles? Maybe reapply edc3c62 too?

Ah - yes, those are exactly the steps. Yes we still need the patch you reference; I got that far in my checking, at least. Also go ahead and bump the version number and write a comment in the .cabal file.

I have to apologize - I've been working really hard for a startup I'm involved with, and it has occupied my attention, leaving little time for open-source work.

If you send a pull request, I promise to merge it immediately and also handle the hackage upload. I've hopefully got a lot more free time moving forward than I have had up to now, since we are out of our time crunch here.

Sent from my iPad

On Nov 8, 2013, at 7:02 PM, Seth Fowler notifications@github.com wrote:

@IreneKnapp Poking once again.

What are the steps involved here? Maybe I can help. Is it just copying in a new sqlite3.c and sqlite3.h and making sure everything still compiles? Maybe reapply edc3c62 too?


Reply to this email directly or view it on GitHub.

No worries; I know how real life can be. =) Just sent over a pull request; let me know if I missed anything.

Thanks - very much appreciated. I particularly like how you unapplied and then reapplied the stat64 thing to make the upgrade smoother. It's uploaded to Hackage now. :)

Awesome! =)