IsThereAnyDeal/AugmentedSteam

[BUG] Empty ITAD notes list causes API request error

Spurlos opened this issue · 0 comments

Expected Behavior

When I do not have any notes in ITAD, extension should not try to fetch data from API using empty gids list.

Actual Behavior

Extension is getting {"status_code":400,"reason_phrase":"Request body must be non-empty JSON array"} from https://api.isthereanydeal.com/lookup/shop/61/id/v1 endpoint by sending empty gids list derived from empty keys of notes list that were retrived from ITAD API over at https://api.isthereanydeal.com/user/notes/v1

My debug journey in screens below:

image
image
image
image
image
image
image
image

Steps to Reproduce the Problem

  1. Enable notes sync in extension options
  2. Ensure that you have no notes set in your ITAD account
  3. Load any page on Steam

Specifications

  • Augmented Steam Version: 4.1.0
  • Browser Version: Version 129.0.6668.12 (Official Build) beta (64-bit)