Who may merge sole maintainer's PRs?

Question

Who may merge sole maintainer's PRs?

mjordan opened this issue 7 years ago · 6 comments

mjordan commented 7 years ago

@rosiel sorry I didn't catch this earlier, but the CONTRIBUTING.md says:

Only maintainers of this module may merge pull requests.
A maintainer may merge anyone's pull requests (except their own)

But if there is only one maintainer as is the case now (Hi! 😄), who is able to merge PRs that the maintainer opens?

Answer 1 · 2017-07-14T23:15:14.000Z

Hi! Um. Well yes that is a problem!

Is "(including their own)" ok?

Also, I can co-maintain if you like.

Answer 2 · 2017-07-14T23:20:28.000Z

I'd say including their own is OK, and sure, it'd be great to have a co-maintainer! I can take care of this change over the weekend if you want.

Answer 3 · 2017-07-14T23:49:05.000Z

It's like a GitHub Barber Paradox 😄

What about "The maintainer(s) of this module and any Islandora Committer may merge pull requests," so you have at least as many potential mergers as the old way, plus maintainers?

Answer 4 · 2017-07-16T20:46:33.000Z

Thanks @rosiel!

Answer 5 · 2017-07-16T21:38:19.000Z

@manez I don't have permission to change settings on this repo. Can you set it so that people can merge approve/merge their own PRs?

Answer 6 · 2017-07-17T13:08:31.000Z

@mjordan I think I have it turned off now, for administrators only (which would be maintainers and Committers)