Instance Color Change Undo Persists
RobertBColton opened this issue · 3 comments
This is a regression, but not because of my recent muddling with the undo. The issue first occurs in 1.8.10 and does not occur in 1.8.6. I can't test any of the versions in between right now due to Java 9 issues with how I included the RTFEditorKit fixes.
Changing the color of an instance creates an undo which persists between room editing sessions. If you change the color of an instance, save the room, and reopen it, the undo will still be available.
Interestingly, the color select only keeps the last color that was entered. It does not keep all of the color change undos, only the very last selected color before the room editor was closed.
After further testing, I discovered that saving the game as a GMX with the instance color stored will persist an undo. It seems as soon as the room editor opens, if the default selected instance has a color other than white, an undo is created.
It seems this is even more complicated, because the Piece interface doesn't have a color getter. The reason it seems is because tiles are storing their color as a long while instances are storing their color as Color objects in their property maps.