Ismoh/NoitaMP

Developer want to improve version and changelog workflow

Ismoh opened this issue · 6 comments

Ismoh commented

When a pull request is merged to develop, version will be increased and changelog will be updated.
Problem on this: Each PR will in crease version and changelog of one version only contains one PR.
Simply looks and feels wrong.
This has to be done on master, but on master the version increase won't work out of the box, because the workflow atm isn't able to fetch all PRs labels.

To fix that, it might be a solution to simply keep the version updated/bumped, when a PR is merged into develop, but it won't update the changelog nor create a tag.

When merging in master, create always a tag and a new changelog.

This will be done, when actionsbot checks comments for Create a tag.
A new release will be created, when develop was merged into master. For this release stuff a new workflow has to be created:

  • increase version
  • update changelog
  • check for comment Create release
  • copy mods\noita-mp content
  • add changelog.md to this content
  • create artifact
  • create a GitHub release
  • put changelog.md content into release description body
Ismoh commented

first good issue and help wanted are broken, when workflow bot copies labels from issue to pull request due to spaces in label names, see #85 (comment)

Ismoh commented

Use Ismoh-Games/find-linked-issues for this
Or
Implement a new GitHub action workflow

Ismoh commented

Commit and push changes is source branch and not in target branch!
When changed, add branch protections again to master and develop!

Ismoh commented

Do this before creating a public release.