IsraelOrtuno/pipedrive

Changes on API endpoints in March 2021

Closed this issue · 10 comments

Pipedrive developers team are going to change some endpoints, among them:

  • GET /deals/find
  • GET /persons/find
  • GET /organizations/find
  • GET /products/find
  • GET /searchResults
  • GET /searchResults/field

There's going to have some update to support these new changes?

Yeah sure, do you have more info about this update?

Sure, here goes the link to their documentation explaining about the changes.

They provide a new endpoint itemSearch

+1 on this issue. Are you accepting PRs? We may be able to help abit.

@MCKLtech I do accept, any help is appreciated

@IsraelOrtuno @MCKLtech The new endpoint for /itemSearch endpoint is supported by #100. Unclear if it supports everything, but I'm guessing it's all good to go? It doesn't address the new search endpoints for individual resources (deals, persons, etc), though.

It does not apply for deals, persons, organizations or products, those are still missing

Not sure if we could include them in this same class to prevent breaking changes in those classes

As far as I'm aware itemSearch is the core functionality and everything else e.g. Deals, Persons is a wrapper of that.

The lazy part of me is wondering can we make the current (And soon to be deprecated) implementations compatible with itemSearch to avoid sudden breakages.

Bringing this back up as it's eminent now. One thing I noticed is the FindByName trait says it is deprecated in your code, but the API documentation doesn't say it will be deprecated for the /Users endpoint.