ItsNickBarry/hardhat-contract-sizer

Display contract sizes in KiB rather than KB

Closed this issue · 5 comments

RyanRHall commented

Contract size limit is 24 KB, or 24576 bytes. The current implementation divides contract size by 1000, rather than 1024, giving a slightly different impression of what the actual contract size is.

ItsNickBarry commented

24576 bytes is equal to 24 KiB or 24.576 KB. This plugin displays data in KB.

However, I didn't realize until now that the limit in KiB is exactly 24, which is more convenient. I may have realized this in the past, but the implementation had some issues and was changed: 779d4c4

I will look into what went wrong with the previous KiB implementation, and likely revert to KiB output for an upcoming release.

RyanRHall commented

Thank you for the clarification and consideration @ItsNickBarry

CumaOzavci commented

I will look into what went wrong with the previous KiB implementation

@ItsNickBarry, any update on this?

ItsNickBarry commented

@CumaOzavci It's not a high priority for me at the moment, but I would accept a PR.

  • 👍1
ItsNickBarry commented

Published in version 2.6.1.

  • ❤️1