Izheil/Quantum-Nox-Firefox-Dark-Full-Theme

Close tab button disappears with Multi-row

emulated24 opened this issue · 5 comments

emulated24 commented

Hi,
when patching Firefox on Mac with Multi-row, the close tab button (little X) disappears when there's more than one row.
Just verified on new installation and new profile.

Can you please fix?

Izheil commented

Are you using the patcher, or manual installation?
Also which version of Mac and multirow? I can't seem to reproduce the issue.
If you used the installer, redownload it, remove the patch, and then reinstall it.

emulated24 commented

Hi,
I'm using the patcher with python3 (3.9.1).

I have macOS Mojave 10.14.6. Multirow is from 3rd of Jan. Firefox version is 84.0.2.
This was a fresh installation of all components with a new profile. Basically, all was from scratch.

I'm happy to provide screenshots of the behaviour if you want.

Izheil commented

I changed the patcher on the 27th of january due to a permissions issue on Mac.
Use the old patcher you have to remove everything, and then patch with the lastest patcher again.

A screenshot would help as well, yes.

None of multirow files have any CSS that affects the close button of tabs, so I'm not sure what could be causing it.

emulated24 commented

Okay, thx for the tip. I did as requested.
It was not showing close tab button again, but I shuffled a bit with tabMinWidth and found strange thing. When I have tabMinWidth set to 130 and 16 tabs are open, button is visible. But when I open 17th tab, close button is gone on all tabs, except the one currently selected.
Then I put 140 as tabMinWidth and the close button is always visible.

Screenshot 2021-02-02 at 09 41 32
Screenshot 2021-02-02 at 09 41 16

Izheil commented

What you mention is the default behaviour of Firefox. Once tabs are too small the close button autohides (even without multirow).
If you want to have the tab close button always visible, you have to add this snippet to your userChrome.css file:

/* TAB CLOSE BUTTON ALWAYS VISIBLE */
#tabbrowser-tabs .tabbrowser-tab:not([pinned]) .tab-close-button {
  	visibility: visible !important;
  	display: block !important}

#tabbrowser-tabs .tabbrowser-tab:not([pinned])[faviconized="true"] .tab-close-button {
  	visibility: collapse !important;
  	display: none !important}

#tabbrowser-tabs .tabbrowser-tab[soundplaying="true"] {
  min-width: calc(var(--tab-min-width) + 18px) !important}
  • 👍1