It might be better to change protobuf::libprotobuf to ${Protobuf_LIBRARIES}, becasue protobuf::libprotobuf doesn't work in the lower version of cmake

Question

It might be better to change protobuf::libprotobuf to ${Protobuf_LIBRARIES}, becasue protobuf::libprotobuf doesn't work in the lower version of cmake

DinghaoZhang opened this issue 5 years ago · 7 comments

In tools/onnx2bnn/CMakeLists.txt, it might be better to change protobuf::libprotobuf to ${Protobuf_LIBRARIES}, becasue protobuf::libprotobuf doesn't work in the lower version of cmake, util cmake 3.9.

Answer 1 · 2019-10-16T02:49:08.000Z

Thanks! I'll fix it soon

Answer 2 · 2019-10-16T03:00:58.000Z

Fixed in #60, merge after CI passes

Answer 3 · 2019-10-16T03:03:03.000Z

BTW, have you joined dabnn QQ group, 1021964010?

Answer 4 · 2019-10-16T03:32:42.000Z

#60 is merged, could you please verify it on your side? thanks!

Answer 5 · 2019-10-17T12:53:21.000Z

#60 is merged, could you please verify it on your side? thanks!

I have changed it. Thank you very much. dabnn is a very useful tool.

Answer 6 · 2019-10-17T12:55:24.000Z

I have changed it. Thank you very much. dabnn is a very useful tool.

Thanks!

Answer 7 · 2019-10-17T12:55:25.000Z

I have changed it. Thank you very much. dabnn is a very useful tool.

Thanks!